From 995db12f224b9645783c6db530e2da421e310758 Mon Sep 17 00:00:00 2001
From: spalger <spalger@users.noreply.github.com>
Date: Thu, 16 Apr 2020 13:58:57 -0700
Subject: [PATCH 1/3] remove arbitrary length limit of forward_host
---
backend/schema/endpoints/proxy-hosts.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/backend/schema/endpoints/proxy-hosts.json b/backend/schema/endpoints/proxy-hosts.json
index af87c46..b472707 100644
--- a/backend/schema/endpoints/proxy-hosts.json
+++ b/backend/schema/endpoints/proxy-hosts.json
@@ -24,8 +24,7 @@
},
"forward_host": {
"type": "string",
- "minLength": 1,
- "maxLength": 50
+ "minLength": 1
},
"forward_port": {
"type": "integer",
From 1d23d5c7613e9282fcb3953001b92bf53457f01d Mon Sep 17 00:00:00 2001
From: spalger <spalger@users.noreply.github.com>
Date: Thu, 16 Apr 2020 15:13:28 -0700
Subject: [PATCH 2/3] remove maxlength from html too
---
frontend/js/app/nginx/proxy/form.ejs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/js/app/nginx/proxy/form.ejs b/frontend/js/app/nginx/proxy/form.ejs
index 3f940f1..254e295 100644
--- a/frontend/js/app/nginx/proxy/form.ejs
+++ b/frontend/js/app/nginx/proxy/form.ejs
@@ -44,7 +44,7 @@
<div class="col-sm-5 col-md-5">
<div class="form-group">
<label class="form-label"><%- i18n('proxy-hosts', 'forward-host') %><span class="form-required">*</span></label>
- <input type="text" name="forward_host" class="form-control text-monospace" placeholder="" value="<%- forward_host %>" autocomplete="off" maxlength="50" required>
+ <input type="text" name="forward_host" class="form-control text-monospace" placeholder="" value="<%- forward_host %>" autocomplete="off" required>
</div>
</div>
<div class="col-sm-4 col-md-4">
From 3af560c2d0c08f8a06e3ad870fa938859fb43ea6 Mon Sep 17 00:00:00 2001
From: spalger <spalger@users.noreply.github.com>
Date: Thu, 16 Apr 2020 15:14:49 -0700
Subject: [PATCH 3/3] switch to 255 limit to match db
---
backend/schema/endpoints/proxy-hosts.json | 3 ++-
frontend/js/app/nginx/proxy/form.ejs | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/backend/schema/endpoints/proxy-hosts.json b/backend/schema/endpoints/proxy-hosts.json
index b472707..9a3fff2 100644
--- a/backend/schema/endpoints/proxy-hosts.json
+++ b/backend/schema/endpoints/proxy-hosts.json
@@ -24,7 +24,8 @@
},
"forward_host": {
"type": "string",
- "minLength": 1
+ "minLength": 1,
+ "maxLength": 255
},
"forward_port": {
"type": "integer",
diff --git a/frontend/js/app/nginx/proxy/form.ejs b/frontend/js/app/nginx/proxy/form.ejs
index 254e295..0cc0d54 100644
--- a/frontend/js/app/nginx/proxy/form.ejs
+++ b/frontend/js/app/nginx/proxy/form.ejs
@@ -44,7 +44,7 @@
<div class="col-sm-5 col-md-5">
<div class="form-group">
<label class="form-label"><%- i18n('proxy-hosts', 'forward-host') %><span class="form-required">*</span></label>
- <input type="text" name="forward_host" class="form-control text-monospace" placeholder="" value="<%- forward_host %>" autocomplete="off" required>
+ <input type="text" name="forward_host" class="form-control text-monospace" placeholder="" value="<%- forward_host %>" autocomplete="off" maxlength="255" required>
</div>
</div>
<div class="col-sm-4 col-md-4">